Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: use IsRetryableError in tidb-tools (#390) #391

Merged
merged 3 commits into from
Dec 3, 2019
Merged

*: use IsRetryableError in tidb-tools (#390) #391

merged 3 commits into from
Dec 3, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Dec 2, 2019

cherry-pick #390 to release-1.0

What problem does this PR solve?

replace IsRetryableError with the one in tidb-tools repo

What is changed and how it works?

  • update tidb-tools mod
  • replace IsRetryableError usage

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@sre-bot sre-bot mentioned this pull request Dec 2, 2019
Merged
@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Dec 2, 2019
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Dec 2, 2019 •
edited
Loading

Codecov Report

Merging #391 into release-1.0 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release-1.0       #391   +/-   ##
==============================================
  Coverage      57.2968%   57.2968%           
==============================================
  Files              159        159           
  Lines            16144      16144           
==============================================
  Hits              9250       9250           
  Misses            5987       5987           
  Partials           907        907

amyangfei
amyangfei reviewed Dec 2, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added the status/LGT1 One reviewer already commented LGTM label Dec 2, 2019
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

WangXiangUSTC
WangXiangUSTC approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Dec 3, 2019
@csuzhangxc csuzhangxc merged commit 9f86c95 into pingcap:release-1.0 Dec 3, 2019
@ericsyh ericsyh added this to the v1.0.3 milestone Dec 3, 2019
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @csuzhangxc @amyangfei @WangXiangUSTC @ericsyh